Added support for Wifi scan options #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
reviewed
Oct 24, 2023
bugadani
reviewed
Oct 24, 2023
|
I don't know what is left do to, but from my point of view, this could be merged. I have added a lot of doc comments. I could also add an example, but I only have an ESP32S3. |
umgefahren
changed the title
bugadani
reviewed
Oct 28, 2023
esp-wifi/src/wifi/mod.rs
Outdated
| impl ScanTypeConfig { | ||
| fn validate(&self) { | ||
| if matches!(self, Self::Passive(dur) if *dur > Duration::from_millis(1500)) { | ||
| #[cfg(feature = "log")] |
There was a problem hiding this comment.
You can just use warn! here
bugadani
reviewed
Oct 28, 2023
|
apart from the small nitpicks about logging this looks good to me |
Co-authored-by: Dániel Buga <[email protected]>
|
I'll run the usual tests on all targets just to make sure it doesn't break anything and if nothing breaks it should be fine to merge I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for WIFI options, enabling advanced configuration and passive scanning.
Could lay the foundation for esp-rs/embedded-svc#57.